linux-kernel - Re: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Nov 2017 19:37:12 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     CK Hu <ck.hu@...iatek.com>
Cc:     ulrich.hecht+renesas@...il.com, laurent.pinchart@...asonboard.com,
        p.zabel@...gutronix.de, airlied@...ux.ie, robh+dt@...nel.org,
        mark.rutland@....com, mturquette@...libre.com,
        sboyd@...eaurora.org, lee.jones@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, mchehab@...nel.org,
        rdunlap@...radead.org, pi-cheng.chen@...aro.org,
        sean.wang@...iatek.com, linux-clk@...r.kernel.org,
        linux@...linux.org.uk, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver



On 11/23/2017 10:04 AM, CK Hu wrote:

>> +static const struct of_device_id of_match_mmsys[] = {
>> +	{ .compatible = "mediatek,mt2701-mmsys",
> 
> Because this driver replace the original "mediatek,mt2701-mmsys" driver,
> could you modify the binding document of "mediatek,mt2701-mmsys" [1]?
> 
> [1]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> 

Well we are actually no replacing the compatible but keeping it. But yes, the
documentation should be updated.

Apart right now we have the definition twice. The other location is here:
Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt

Regards,
Matthias