linux-kernel - [tip:irq/urgent] irqchip/qcom: Fix u32 comparison with value less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-e9990d70e8a063a7b894c5cbb99f630a0f41200d@git.kernel.org>
Date:   Thu, 23 Nov 2017 11:09:59 -0800
From:   tip-bot for Colin Ian King <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, jason@...edaemon.net, mingo@...nel.org,
        colin.king@...onical.com, hpa@...or.com, marc.zyngier@....com,
        linux-kernel@...r.kernel.org
Subject: [tip:irq/urgent] irqchip/qcom: Fix u32 comparison with value less
 than zero

Commit-ID:  e9990d70e8a063a7b894c5cbb99f630a0f41200d
Gitweb:     https://git.kernel.org/tip/e9990d70e8a063a7b894c5cbb99f630a0f41200d
Author:     Colin Ian King <colin.king@...onical.com>
AuthorDate: Fri, 17 Nov 2017 18:35:53 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 23 Nov 2017 20:03:58 +0100

irqchip/qcom: Fix u32 comparison with value less than zero

The comparison of u32 nregs being less than zero is never true since
nregs is unsigned. Fix this by making nregs a signed integer.

Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: kernel-janitors@...r.kernel.org
Cc: Jason Cooper <jason@...edaemon.net>
Link: https://lkml.kernel.org/r/20171117183553.2739-1-colin.king@canonical.com

---
 drivers/irqchip/qcom-irq-combiner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 6aa3ea4..f312659 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev)
 {
 	struct combiner *combiner;
 	size_t alloc_sz;
-	u32 nregs;
+	int nregs;
 	int err;
 
 	nregs = count_registers(pdev);