linux-kernel - Re: [PATCH v2 05/18] x86/fixmap: Generalize the GDT fixmap mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711232023080.2364@nanos>
Date:   Thu, 23 Nov 2017 20:24:47 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andy Lutomirski <luto@...nel.org>
cc:     X86 ML <x86@...nel.org>, Borislav Petkov <bpetkov@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brian Gerst <brgerst@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH v2 05/18] x86/fixmap: Generalize the GDT fixmap
 mechanism

On Tue, 21 Nov 2017, Andy Lutomirski wrote:

> Currently, the GDT is an ad-hoc array of pages, one per CPU, in the
> fixmap.  Generalize it to be an array of a new struct cpu_entry_area
> so that we can cleanly add new things to it.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

> +/*
> + * cpu_entry_area is a percpu region in the fixmap that contains things
> + * needed by the CPU and early entry/exit code.  Real types aren't used
> + * for all fields here to about circular header dependencies.

s/to about/to avoid/ ???

Other than that.

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>