linux-kernel - Re: [PATCH] fat: Fix sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511470178.5308.2.camel@perches.com>
Date:   Thu, 23 Nov 2017 12:49:38 -0800
From:   Joe Perches <joe@...ches.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fat: Fix sb_rdonly() change

On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote:
> Ouch forgot to add stable@
> 
> -- 
> commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug.

I think your commit message needs a bit more information.

It'd be useful to describe that the introduction of
sb_rdonly converted the bitwise & to a boolean and so
this conversion and comparison was made defective.

Are there any other instances of defective comparisons?