linux-kernel - Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511479945.8829.1.camel@gmail.com>
Date:   Fri, 24 Nov 2017 00:32:25 +0100
From:   Stefano Manni <stefano.manni@...il.com>
To:     "Tobin C. Harding" <me@...in.cc>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        lustre-devel@...ts.lustre.org
Subject: Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from
 sparse

On Fri, 2017-11-24 at 09:20 +1100, Tobin C. Harding wrote:
> On Thu, Nov 23, 2017 at 02:51:38PM +0300, Dan Carpenter wrote:
> > On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote:
> > > On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote:
> > > > Fixed some signedness warnings from sparse on lustre.
> > > > 
> > > > Stefano Manni (4):
> > > >   staging: lustre: fixed signedness of some socklnd params
> > > >   staging: lustre: fixed signedness of llite
> > > >   staging: lustre: fixed signedness of lov
> > > >   staging: lustre: fixed signedness of obdclass
> > > 
> > > You may like to use imperative mood for your git log brief
> > > descriptions
> > > Stefano.  
> > > 
> > > s/fixed/fix/
> > > 
> > 
> > Someone once chewed me a second butt hole for not using the
> > imperative
> > mood so I know some people care intensely about this but I think so
> > long
> > as you can understand the description it's fine.  I will never send
> > a
> > patch for that maintainer's subsystem again, btw, which is probably
> > grateful for and now I can poop twice as fast so we're both
> > winners.
> 
> I try to only make these suggestions to people doing clean up patches
> to
> staging, with the reasoning that if we are learning we might as well
> learn the correct method from the start.

It's ok with your suggestion. Not a hard work to rebase 4 commit and
change the commit message.

Thanks,
Stefano