lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 23 Nov 2017 10:45:25 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     myungjoo.ham@...sung.com, Joe Perches <joe@...ches.com>,
        Kyungmin Park <kyungmin.park@...sung.com>
Cc:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

On 2017년 11월 23일 10:21, MyungJoo Ham wrote:
>> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote:
>>> On 2017년 11월 17일 00:27, Joe Perches wrote:
>>>> Line continuations with excess spacing causes unexpected output.
>>>>
>>>> Signed-off-by: Joe Perches <joe@...ches.com>
>>>> ---
>>>>  drivers/devfreq/rk3399_dmc.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>>>> index 5dfbfa3cc878..0938c97d46f0 100644
>>>> --- a/drivers/devfreq/rk3399_dmc.c
>>>> +++ b/drivers/devfreq/rk3399_dmc.c
>>>> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq,
>>>>  
>>>>  	/* If get the incorrect rate, set voltage to old value. */
>>>>  	if (dmcfreq->rate != target_rate) {
>>>> -		dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\
>>>> -			Current frequency %lu\n", target_rate, dmcfreq->rate);
>>>> +		dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n",
>>>> +			target_rate, dmcfreq->rate);
>>>
>>> IMO, I don't like over 80 char in the one line.
>>
>> Fix it as you chose, but the code I proposed
>> is what is preferred by CodingStyle.
>>
>> The current code is unintentional.
>>
>> Right now there are 3 tabs between "Request frequency"
>> and "Current frequency" in the output.
> 
> Chanwoo, this is not a simple coding style issue.
> I'm seeing these unintentional tabs as well.
> 
> If you want to keep it 80 cols with strings (which is not mandatory for strings in double quotes),
> We'd better do:
> 
> -		dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\
> -			Current frequency %lu\n", target_rate, dmcfreq->rate);
> +		dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,"
> +			" Current frequency %lu\n", target_rate, dmcfreq->rate);

I agree with Myungjoo's opinion.
I think the readability is important. So, I prefer to keep one line within 80 char.

> 
> Cheers,
> MyungJoo
> 
>>
>>>>  		regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt,
>>>>  				      dmcfreq->volt);
>>>>  		goto out;
>>>>
>>>
>>>
>>
> 
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Powered by blists - more mailing lists