linux-kernel - Re: [PATCH v7 3/5] bpf: add a bpf_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b416c77-33f8-dacc-82c3-811a265155ed@iogearbox.net>
Date:   Fri, 24 Nov 2017 10:46:28 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Josef Bacik <josef@...icpanda.com>, rostedt@...dmis.org,
        mingo@...hat.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ast@...nel.org, kernel-team@...com,
        linux-btrfs@...r.kernel.org
Cc:     Josef Bacik <jbacik@...com>
Subject: Re: [PATCH v7 3/5] bpf: add a bpf_override_function helper

On 11/22/2017 10:23 PM, Josef Bacik wrote:
> From: Josef Bacik <jbacik@...com>
> 
> Error injection is sloppy and very ad-hoc.  BPF could fill this niche
> perfectly with it's kprobe functionality.  We could make sure errors are
> only triggered in specific call chains that we care about with very
> specific situations.  Accomplish this with the bpf_override_funciton
> helper.  This will modify the probe'd callers return value to the
> specified value and set the PC to an override function that simply
> returns, bypassing the originally probed function.  This gives us a nice
> clean way to implement systematic error injection for all of our code
> paths.
> 
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> Acked-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Josef Bacik <jbacik@...com>

Series looks good to me as well; BPF bits:

Acked-by: Daniel Borkmann <daniel@...earbox.net>