linux-kernel - Re: [PATCH] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5D62MHAbJSsUhTV+HcWeN4AZ_ePE+jRHA=dRzxgmO==LQ@mail.gmail.com>
Date:   Fri, 24 Nov 2017 11:44:47 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Otavio Salvador <otavio@...ystems.com.br>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Gary Bisson <gary.bisson@...ndarydevices.com>,
        Fabio Estevam <fabio.estevam@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions

On Fri, Nov 24, 2017 at 9:21 AM, Otavio Salvador
<otavio@...ystems.com.br> wrote:

> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index 4bdf29169d2a..f8b267875e1c 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -276,6 +276,23 @@
>                 compatible = "sst,sst25vf016b", "jedec,spi-nor";
>                 spi-max-frequency = <20000000>;
>                 reg = <0>;
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +
> +               partition@0 {
> +                       label = "U-Boot";

What about calling it something more generic, like "bootloader"?

U-Boot is not the only bootloader that can run on this board.

You could also consider passing the 'read-only' property like it is
done in imx6sx-nitrogen6sx.dts.

> +                       reg = <0x0 0xc0000>;
> +               };
> +
> +               partition@...00 {
> +                       label = "U-Boot Environment";

Maybe just 'env' and add  'read-only' property here as well.