linux-kernel - Re: [PATCH 11/43] x86/entry/64: Separate cpu_current_top_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171124141900.lrxeed3qepxtiyzp@pd.tnic>
Date:   Fri, 24 Nov 2017 15:19:00 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...capital.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 11/43] x86/entry/64: Separate cpu_current_top_of_stack
 from TSS.sp0

On Fri, Nov 24, 2017 at 10:14:16AM +0100, Ingo Molnar wrote:
> From: Andy Lutomirski <luto@...nel.org>
> 
> On 64-bit kernels, we used to assume that TSS.sp0 was the current
> top of stack.  With the addition of an entry trampoline, this will
> no longer be the case.  Store the current top of stack in TSS.sp1,
> which is otherwise unused but shares the same cacheline.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Borislav Petkov <bpetkov@...e.de>
> Cc: Brian Gerst <brgerst@...il.com>
> Cc: Dave Hansen <dave.hansen@...el.com>
> Cc: Denys Vlasenko <dvlasenk@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Link: http://lkml.kernel.org/r/f56634c746a2926eb7bae61e7b80ed51a1940769.1511497875.git.luto@kernel.org
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> ---
>  arch/x86/include/asm/processor.h   | 18 +++++++++++++-----
>  arch/x86/include/asm/thread_info.h |  2 +-
>  arch/x86/kernel/asm-offsets_64.c   |  1 +
>  arch/x86/kernel/process.c          | 10 ++++++++++
>  arch/x86/kernel/process_64.c       |  1 +
>  5 files changed, 26 insertions(+), 6 deletions(-)

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.