linux-kernel - Re: [PATCH v8 4/5] crash: export paddr_vmcoreinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171124061759-mutt-send-email-mst@kernel.org>
Date:   Fri, 24 Nov 2017 06:20:35 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Marc-André Lureau 
        <marcandre.lureau@...hat.com>, linux-kernel@...r.kernel.org,
        somlo@....edu, xiaolong.ye@...el.com, qemu-devel@...gnu.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Baoquan He <bhe@...hat.com>, Dave Young <dyoung@...hat.com>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Tony Luck <tony.luck@...el.com>,
        Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note()

On Thu, Nov 23, 2017 at 06:36:57AM -0800, Christoph Hellwig wrote:
> On Thu, Nov 23, 2017 at 03:02:05PM +0100, Marc-André Lureau wrote:
> > The following patch is going to use the symbol from the fw_cfg module,
> > to call the function and write the note location details in the
> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
> 
> Sounds like fw_cfg should be moved to be built in only instead of
> exporting such a symbol address.

Point is, all fw cfg does is export it on to the hypervisor, so it will
have to be supported forever.  If it's safe to export it to the
hypervisor then for sure it's also safe to export it to modules.

-- 
MST