linux-kernel - Re: [PATCH 1/3] net: core: export dev_alloc_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171125.051143.1746775828505862683.davem@davemloft.net>
Date:   Sat, 25 Nov 2017 05:11:43 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     linux@...musvillemoes.dk
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] net: core: export dev_alloc_name_ns

From: Rasmus Villemoes <linux@...musvillemoes.dk>
Date: Tue, 21 Nov 2017 01:34:37 +0100

> dev_alloc_name_ns and dev_get_valid_name now do exactly the same
> thing. Let's expose this functionality as dev_alloc_name_ns
> (obviously, a core function like this won't return an invalid
> name...).
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

If you're going to keep one of the routines, keep the one with
the simpler and smaller name, "dev_get_valid_name".