lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 Nov 2017 21:18:16 +0000
From:   David Howells <>
To:     Eric Biggers <>
Cc:,,,, Eric Biggers <>
Subject: Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

Eric Biggers <> wrote:

> > > -			construct_get_dest_keyring(&dest_keyring);
> > 
> > This will break.  construct_get_dest_keyring() does other things than just
> > getting a ref on whatever dest_keyring points to.
> > 
> Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in
> this case.

Actually, you're right.


Powered by blists - more mailing lists