linux-kernel - Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5478.1511558296@warthog.procyon.org.uk>
Date:   Fri, 24 Nov 2017 21:18:16 +0000
From:   David Howells <dhowells@...hat.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

Eric Biggers <ebiggers3@...il.com> wrote:

> > > -			construct_get_dest_keyring(&dest_keyring);
> > 
> > This will break.  construct_get_dest_keyring() does other things than just
> > getting a ref on whatever dest_keyring points to.
> > 
> 
> Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in
> this case.

Actually, you're right.

David