lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 25 Nov 2017 00:41:43 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     TimGuo <timguo_via@...yun.com>
cc:     mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        brucechang@...-alliance.com, benjaminpan@...tech.com,
        cooperyan@...oxin.com, qiyuanwang@...oxin.com
Subject: Re: [PATCH] This patch is used ... [trimmed overly long subject]

Tim,

Your patch looks good, but your patch description needs some care:

Please do not write full sentences in the subject line. The subject line
should be a short and precise information about the patch. The format is:

       [PATCH] subsystem: Short precise description.

in this case:

       [PATCH] x86/centaur: Mark TSC invariant

Then you add a decsription of the change in the body of the mail. Please
avoid wording like 'This patch does ...'. We already know that this is a
patch and the description should be more focussed on the WHY than on the
WHAT. The WHAT can be seen from the patch itself, but the WHY is the
information which is not in the code.

See also Documentation/process/submitting-patches.rst

Thanks,

	tglx

Powered by blists - more mailing lists