linux-kernel - [PATCH] mm/page_alloc: fix comment is __get_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1511591359-11448-1-git-send-email-chenjiankang1@huawei.com>
Date:   Sat, 25 Nov 2017 14:29:19 +0800
From:   JianKang Chen <chenjiankang1@...wei.com>
To:     <akpm@...ux-foundation.org>, <mhocko@...e.com>,
        <mgorman@...hsingularity.net>, <hillf.zj@...baba-inc.com>
CC:     <hannes@...xchg.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <xieyisheng1@...wei.com>,
        <guohanjun@...wei.com>, <wangkefeng.wang@...wei.com>
Subject: [PATCH] mm/page_alloc: fix comment is __get_free_pages

From: c00426987 <c00426987@...wei.com>

__get_free_pages will return an 64bit address in 64bit System
like arm64 or x86_64. And this comment really
confuse new bigenner of mm.

reported-by: Hanjun Guo <guohanjun@...wei.com>
Signed-off-by: Chen Jiankang <chenjiankang1@...wei.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 77e4d3c..b847b24 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4240,8 +4240,8 @@ unsigned long __get_free_pages(gfp_t gfp_mask, unsigned int order)
 	struct page *page;
 
 	/*
-	 * __get_free_pages() returns a 32-bit address, which cannot represent
-	 * a highmem page
+	 * __get_free_pages() returns a virtual address, which
+	 * cannot represent a highmem page
 	 */
 	VM_BUG_ON((gfp_mask & __GFP_HIGHMEM) != 0);
 
-- 
1.7.12.4