lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Nov 2017 13:41:54 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: Ingo Molnar <mingo@...nel.org> cc: linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski <luto@...capital.net>, "H . Peter Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, Borislav Petkov <bp@...en8.de>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH 22/43] x86/mm/kaiser: Prepare assembly for entry/exit CR3 switching On Sat, 25 Nov 2017, Thomas Gleixner wrote: > On Fri, 24 Nov 2017, Ingo Molnar wrote: > > @@ -1288,6 +1308,8 @@ ENTRY(error_entry) > > * from user mode due to an IRET fault. > > */ > > SWAPGS > > + /* We have user CR3. Change to kernel CR3. */ > > + SWITCH_TO_KERNEL_CR3 scratch_reg=%rax > > > > .Lerror_entry_from_usermode_after_swapgs: > > /* Put us onto the real thread stack. */ > > @@ -1333,6 +1355,7 @@ ENTRY(error_entry) > > * gsbase and proceed. We'll fix up the exception and land in > > * .Lgs_change's error handler with kernel gsbase. > > */ > > + SWITCH_TO_KERNEL_CR3 scratch_reg=%rax > > SWAPGS > > This is wrong. SWAPGS needs to come first. With this fixed: Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
Powered by blists - more mailing lists