linux-kernel - Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171126172847.dxdqckearsd34kge@pd.tnic>
Date:   Sun, 26 Nov 2017 18:28:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Andy Lutomirski <luto@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on
 the entry stack

On Sun, Nov 26, 2017 at 03:05:33PM +0100, Ingo Molnar wrote:
> > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/entry_stack&id=6510485d026abdd144d170b1bc8508327acb5648
> 
> I have added Boris's reviewed-by tag:
> 
>   Reviewed-by: Borislav Petkov <bp@...e.de>
> 
> which I suspect applies now?

Almost, looking at the patch at that URL, there's a trailing "modify" in the
comment:

+	 * we land directly at the #GP(0) vector with the stack already
+	 * set up according to its expectations.modify
						^^^^^^
which you can amend-remove.

Other than that, it looks good!

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.