linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com>
Date:   Sun, 26 Nov 2017 10:47:29 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line

On 26/11/17 10:09 AM, Julia Lawall wrote:
> I don't know.  In any case, a Coccinelle script would get run by the 0-day
> build testing service, which checks lots of trees.  Perhaps both are
> useful, since Joe had some conerns about the amount of relevant context
> available in a patch.

Yup, both could certainly be useful. A coccinelle script would likely be
able to catch a few false negatives that might pass through the
checkpatch script. It'll likely have similar difficulties with
KERN_CONTs though.

Also, I don't really know, but it might be tough enabling a script to
run on 0-day with the ~6000 potential errors already existing.

Logan