linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Nov 2017 14:29:42 -0800
From:   Joe Perches <joe@...ches.com>
To:     Logan Gunthorpe <logang@...tatee.com>,
        Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line

On Sun, 2017-11-26 at 10:38 -0700, Logan Gunthorpe wrote:
> 
> On 25/11/17 11:01 PM, Joe Perches wrote:
> > It doesn't really work.
> 
> That's rather hyperbolic and I don't appreciate the tone.

What I wrote is neither hyperbolic nor tonal.

I'm rather familiar with checkpatch.

High false positive messages are avoided by checkpatch and
new tests with high false positive rates are not accepted.

This proposal has a very high false positive rate.

So, as written.  nack.

Keep at it though.
Maybe something useful will be produced with more effort.

cheers, Joe