lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 25 Nov 2017 16:42:59 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Martin Kepplinger <martink@...teo.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: pegasus_notetaker: add license information

Hi Martin,

On Sat, Nov 18, 2017 at 09:45:18AM +0100, Martin Kepplinger wrote:
> This adds an SPDX license identifier to this driver I wrote some time back.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>
> ---
>  drivers/input/tablet/pegasus_notetaker.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c
> index 47de5a81172f..cdf75c989469 100644
> --- a/drivers/input/tablet/pegasus_notetaker.c
> +++ b/drivers/input/tablet/pegasus_notetaker.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0

Should this be GPL-2.0+? The MODULE_LICENSE specifies that the module is
"GPL" which in kernel land means GPLv2+. Or we should change the module
license to strict "GPLv2"?

Also, why do we use C++ -style comments for this?

Greg, do you have any plans on dropping MODULE_LICENSE() altogether and
generating the appropriate string from SPDX markings in the source?
Doing this would prevent mismatches between license notices, SPDX tags
and MODULE_LCENSE() strings, which happen very often.

>  /*
>   * Pegasus Mobile Notetaker Pen input tablet driver
>   *

Thanks.

-- 
Dmitry

Powered by blists - more mailing lists