linux-kernel - Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 14:46:39 -0500
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'Sinan Kaya'" <okaya@...eaurora.org>, <linux-pci@...r.kernel.org>,
        <timur@...eaurora.org>
Cc:     <linux-arm-msm@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <intel-gfx@...ts.freedesktop.org>,
        "'Lee Jones'" <lee.jones@...aro.org>,
        "'Daniel Thompson'" <daniel.thompson@...aro.org>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@...sung.com>,
        "'open list:FRAMEBUFFER LAYER'" <linux-fbdev@...r.kernel.org>,
        "'open list'" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot()

On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote:
> 
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.

I think that this will be useful. I introduced multi domains into
ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose
domain will be used later.

> 
> Getting ready to remove pci_get_bus_and_slot() function in favor of
> pci_get_domain_bus_and_slot().
> 
> Hard-coding the domain as 0.
> 
> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> Signed-off-by: Sinan Kaya <okaya@...eaurora.org>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> ---
>  drivers/video/backlight/apple_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/apple_bl.c
> b/drivers/video/backlight/apple_bl.c
> index d843296..6a34ab9 100644
> --- a/drivers/video/backlight/apple_bl.c
> +++ b/drivers/video/backlight/apple_bl.c
> @@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev)
>  	struct pci_dev *host;
>  	int intensity;
> 
> -	host = pci_get_bus_and_slot(0, 0);
> +	host = pci_get_domain_bus_and_slot(0, 0, 0);
> 
>  	if (!host) {
>  		pr_err("unable to find PCI host\n");
> --
> 1.9.1