lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 27 Nov 2017 14:29:59 -0800
From:   Deepa Dinamani <>
To:     Arnd Bergmann <>
Cc:     Thomas Gleixner <>,
        John Stultz <>,
        Linux Kernel Mailing List <>,
        y2038 Mailman List <>,
        Arnaldo Carvalho de Melo <>,
        Benjamin Herrenschmidt <>,
        Christian Borntraeger <>,
        Catalin Marinas <>,
        Chris Metcalf <>,,
        David Miller <>,
        Helge Deller <>,,, gregkh <>,
        Heiko Carstens <>,
        Jan Hoeppner <>,
        "H. Peter Anvin" <>,
        "James E.J. Bottomley" <>,
        Julian Wiedmann <>,
        Linux API <>,
        linux-arch <>,
        "open list:RALINK MIPS ARCHITECTURE" <>,
        Parisc List <>,
        linuxppc-dev <>,
        linux-s390 <>,
        Mark Rutland <>,
        Ingo Molnar <>,
        Michael Ellerman <>,,,
        Paul Mackerras <>,
        Peter Zijlstra <>,
        Ralf Baechle <>,
        Steven Rostedt <>,
        Robert Richter <>,
        Martin Schwidefsky <>,, sparclinux <>,
        Stefan Haberland <>,
        Ursula Braun <>,
        Will Deacon <>,
        "the arch/x86 maintainers" <>
Subject: Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

>> I decided against using LEGACY_TIME_SYSCALLS to conditionally compile
>> legacy time syscalls such as sys_nanosleep because this will need to
>> enclose compat_sys_nanosleep as well. So, defining it as
>>      def_bool 64BIT || !64BIT_TIME
>> will not include compat_sys_nanosleep. We will instead need a new config to
>> exclusively mark legacy syscalls.
> Do you mean we would need to do this separately for native and compat
> syscalls, and have yet another option, like LEGACY_TIME_SYSCALLS
> and LEGACY_TIME_COMPAT_SYSCALLS, to cover all cases? I would
> think that CONFIG_COMPAT_32BIT_TIME handles all the compat versions,
> while CONFIG_LEGACY_TIME_SYSCALLS handles all the native ones.

I meant sys_nanosleep would be covered by LEGACY_TIME_SYSCALLS, but
compat_sys_nanosleep would be covered by CONFIG_COMPAT_32BIT_TIME
along with other compat syscalls.
So, if we define the LEGACY_TIME_SYSCALLS as

        "This controls the compilation of the following system calls:
        time, stime, gettimeofday, settimeofday, adjtimex, nanosleep,
alarm, getitimer,
        setitimer, select, utime, utimes, futimesat, and
        These all pass 32-bit time_t arguments on 32-bit architectures and
        are replaced by other interfaces (e.g. posix timers and clocks, statx).
        C libraries implementing 64-bit time_t in 32-bit architectures have to
        implement the handles by wrapping around the newer interfaces.
        New architectures should not explicitly enable this."

This would not be really true as compat interfaces have nothing to do
with this config.

I was proposing that we could have LEGACY_TIME_SYSCALLS config, but
then have all these "deprecated" syscalls be enclosed within this,
compat or not.
This will also mean that we will have to come up representing these
syscalls in the syscall header files.
This can be a separate patch and this series can be merged as is if
everyone agrees.


Powered by blists - more mailing lists