linux-kernel - Re: [PATCH] s390/drivers: use setup_timer instead of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <53a7d0e2-93f6-e69e-ef49-57d3a46714c5@linux.vnet.ibm.com>
Date:   Mon, 27 Nov 2017 08:25:51 +0100
From:   Julian Wiedmann <jwi@...ux.vnet.ibm.com>
To:     Colin King <colin.king@...onical.com>,
        Ursula Braun <ubraun@...ux.vnet.ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-s390@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/drivers: use setup_timer instead of init_timer

On 11/24/2017 01:50 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Use setup_timer function instead of initializing timer with the
> function and data fields.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/s390/net/fsm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/s390/net/fsm.c b/drivers/s390/net/fsm.c
> index 8c14c6c3ad3d..16b81be1f07a 100644
> --- a/drivers/s390/net/fsm.c
> +++ b/drivers/s390/net/fsm.c
> @@ -142,13 +142,11 @@ void
>  fsm_settimer(fsm_instance *fi, fsm_timer *this)
>  {
>  	this->fi = fi;
> -	this->tl.function = (void *)fsm_expire_timer;
> -	this->tl.data = (long)this;
>  #if FSM_TIMER_DEBUG
>  	printk(KERN_DEBUG "fsm(%s): Create timer %p\n", fi->name,
>  	       this);
>  #endif
> -	init_timer(&this->tl);
> +	setup_timer(&this->tl, (void *)fsm_expire_timer, (long)this);
>  }
> 
>  void
> 

Thanks Colin, but looks like Kees beat you to it in Linus' tree.