linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711270951450.3445@hadrien>
Date:   Mon, 27 Nov 2017 09:52:15 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Joe Perches <joe@...ches.com>
cc:     Logan Gunthorpe <logang@...tatee.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line



On Mon, 27 Nov 2017, Joe Perches wrote:

> On Sun, 2017-11-26 at 23:40 -0700, Logan Gunthorpe wrote:
> >
> > On 26/11/17 11:34 PM, Julia Lawall wrote:
> > > It would probably be better not to mention the KERN_CONT possibility at
> > > all.
> >
> > Oh? I don't disagree... but what are we supposed to do in these cases?
> > The way v2 of my patch works it just says that there is a missing new
> > line. But Joe calls that a false positive. So if we can't report that
> > it's missing a new line and we can't say it looks like it needs a
> > KERN_CONT, then what can we do? The case is obviously wrong in some way
> > or another so we probably shouldn't just ignore it.

I meant why not only suggest pr_cont?

julia

>
> checkpatch already reports printks without KERN_<level>
>
> # printk should use KERN_* levels
> 		if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
> 			WARN("PRINTK_WITHOUT_KERN_LEVEL",
> 			     "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
> 		}
>
>