linux-kernel - Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171127091541.GA23299@dhcp-128-65.nay.redhat.com>
Date:   Mon, 27 Nov 2017 17:15:41 +0800
From:   Dave Young <dyoung@...hat.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Jiri Kosina <jikos@...nel.org>, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

On 11/27/17 at 09:49am, Benjamin Tissoires wrote:
> On Nov 27 2017 or thereabouts, Greg KH wrote:
> > On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote:
> > > On Nov 25 2017 or thereabouts, Dave Young wrote:
> > > > This mouse keep disconnecting in runleve 3 like below, add it needs the
> > > > quirk to mute the anoying messages.
> > > > 
> > > > [  111.230555] usb 2-2: USB disconnect, device number 6
> > > > [  112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd
> > > > [  112.941594] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a
> > > > [  112.984866] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> > > > [  113.027731] usb 2-2: Product: HP USB Optical Mouse
> > > > [  113.069977] usb 2-2: Manufacturer: PixArt
> > > > [  113.113500] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0002/input/input14
> > > > [  113.156787] hid-generic 0003:03F0:094A.0002: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0
> > > > [  173.262642] usb 2-2: USB disconnect, device number 7
> > > > [  174.750244] usb 2-2: new low-speed USB device number 8 using xhci_hcd
> > > > [  174.935740] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a
> > > > [  174.990435] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> > > > [  175.014984] usb 2-2: Product: HP USB Optical Mouse
> > > > [  175.037886] usb 2-2: Manufacturer: PixArt
> > > > [  175.061794] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0003/input/input15
> > > > [  175.084946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0
> > > > 
> > > > Signed-off-by: Dave Young <dyoung@...hat.com>
> > > > ---
> > > >  drivers/hid/hid-ids.h           |    1 +
> > > >  drivers/hid/usbhid/hid-quirks.c |    1 +
> > > 
> > > Patch looks good and should be good for stable too, but in the file
> > > hid-quirks.c file has been moved one folder up. Please rebase the patch
> > > on top of https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/log/?h=for-4.16/hid-quirks-cleanup/_base
> > > It should be merged in linux-next in the next few days normally.
> > > 
> > > Jiri, how can we deal with such stable-ish patches?
> > 
> > I can almost always handle things as simple as file movements, don't
> > worry about that.  If there's a problem, I'll be sure to let people know
> > :)
> > 
> 
> OK, thanks Greg.
> 
> Dave, please rebase on top of the branch I mentioned before, and add
> also the stable@ tag.

Benjamin, will do.

I posted this when I was in my daughter's class last weekend, maybe I
can retest and repost it next Saturday at Dec 4th or earlier if
I can find free time before that :)

> 
> Cheers,
> Benjamin

Thanks
Dave