linux-kernel - Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171127091916.4u4kmbqjixjwg76q@gmail.com>
Date:   Mon, 27 Nov 2017 10:19:16 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Andy Lutomirski <luto@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on
 the entry stack


* Borislav Petkov <bp@...en8.de> wrote:

> On Sun, Nov 26, 2017 at 03:05:33PM +0100, Ingo Molnar wrote:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/entry_stack&id=6510485d026abdd144d170b1bc8508327acb5648
> > 
> > I have added Boris's reviewed-by tag:
> > 
> >   Reviewed-by: Borislav Petkov <bp@...e.de>
> > 
> > which I suspect applies now?
> 
> Almost, looking at the patch at that URL, there's a trailing "modify" in the
> comment:
> 
> +	 * we land directly at the #GP(0) vector with the stack already
> +	 * set up according to its expectations.modify
> 						^^^^^^
> which you can amend-remove.

Oops - fixed.

> Other than that, it looks good!

Thanks!

	Ingo