linux-kernel - Re: [PATCH 20/43] x86/entry: Clean up SYSENTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171127092727.lktzrtylt2ed5sfz@hirez.programming.kicks-ass.net>
Date:   Mon, 27 Nov 2017 10:27:27 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 20/43] x86/entry: Clean up SYSENTER_stack code

On Sat, Nov 25, 2017 at 09:26:38AM -0800, Andy Lutomirski wrote:
> On Sat, Nov 25, 2017 at 9:10 AM, Borislav Petkov <bp@...en8.de> wrote:
> > On Sat, Nov 25, 2017 at 06:03:36PM +0100, Thomas Gleixner wrote:
> >> > Maybe I should rename cpu_tss to cpu_tss_rw in that patch.
> >>
> >> For clarity that would be nice.
> >
> > + a comment stating the alias mapping. It took tglx and me a while on
> > IRC to figure it out. :-)
> 
> I'm adding this comment to the top of cpu_entry_area:
> 
> + * Every field is a virtual alias of some other allocated backing store.
> + * There is no direct allocation of a struct cpu_entry_area.

Right, thanks! That did take me a few minutes to sort as well :-)