linux-kernel - Re: [PATCH] drm/rockchip: dma-mapping: Use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 10:20:20 +0800
From:   Sandy Huang <hjc@...k-chips.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     linux-kernel@...r.kernel.org, airlied@...ux.ie, heiko@...ech.de,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper

Thanks, this update has merged to drm-misc-next months ago:

https://patchwork.freedesktop.org/patch/178255/


在 2017/11/22 23:24, Vasyl Gomonovych 写道:
> Use vma_pages function on vma object instead of explicit computation.
> ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1869c8bb76c8..1d9655576b6e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
>   {
>       struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
>       unsigned int i, count = obj->size >> PAGE_SHIFT;
> -    unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +    unsigned long user_count = vma_pages(vma);
>       unsigned long uaddr = vma->vm_start;
>       unsigned long offset = vma->vm_pgoff;
>       unsigned long end = user_count + offset;
>