linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com>
Date:   Sun, 26 Nov 2017 21:00:36 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Joe Perches <joe@...ches.com>, Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line

On 26/11/17 03:29 PM, Joe Perches wrote:
> This proposal has a very high false positive rate.

The only actual false positive you've pointed out is the one that is
just incorrect in the wrong way (the author should have used a KERN_CONT
but did not). I could easily do something similar to what Julia proposes
and produce a different warning if the string ends in a space. But I
don't see any bullet proof way for any script to deduce what the author
actually meant.

> Keep at it though.
> Maybe something useful will be produced with more effort.

Unless there's more actually constructive criticism I don't think I'll
be getting any further with this.

Logan