linux-kernel - RE: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <F3B0350DF4CB6849A642218320DE483D7D683A8B@SHSMSX104.ccr.corp.intel.com>
Date:   Mon, 27 Nov 2017 12:14:19 +0000
From:   "Wang, Zhi A" <zhi.a.wang@...el.com>
To:     David Binderman <dcb314@...mail.com>,
        "zhenyuw@...ux.intel.com" <zhenyuw@...ux.intel.com>,
        "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
        "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "intel-gvt-dev@...ts.freedesktop.org" 
        <intel-gvt-dev@...ts.freedesktop.org>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor
 error checking ?

Thanks for the email. It has been refined recently, the code can be found here:

https://cgit.freedesktop.org/drm-intel/tree/drivers/gpu/drm/i915/gvt/cmd_parser.c

Thanks for the notification, again. :)

-----Original Message-----
From: David Binderman [mailto:dcb314@...mail.com] 
Sent: Monday, November 27, 2017 1:59 PM
To: zhenyuw@...ux.intel.com; Wang, Zhi A <zhi.a.wang@...el.com>; jani.nikula@...ux.intel.com; joonas.lahtinen@...ux.intel.com; Vivi, Rodrigo <rodrigo.vivi@...el.com>; airlied@...ux.ie; intel-gvt-dev@...ts.freedesktop.org; intel-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?


Hello there,

linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero.

Source code is

    /* get the size of the batch buffer */
    bb_size = find_bb_size(s);
    if (bb_size < 0)
        return -EINVAL;

but

static int find_bb_size(struct parser_exec_state *s)

so the code isn't properly checking the return value. Suggest code rework.

Regards

David Binderman