linux-kernel - Re: [PATCH 2/2] ARM: davinci: make davinci_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19265c2a-4ae4-a2f8-3ddf-01c2a4c2b11a@ti.com>
Date:   Mon, 27 Nov 2017 18:12:59 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Bhumika Goyal <bhumirks@...il.com>, <julia.lawall@...6.fr>,
        <khilman@...nel.org>, <linux@...linux.org.uk>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: davinci: make davinci_soc_info structures const

On Monday 16 October 2017 03:38 PM, Bhumika Goyal wrote:
> This is a followup patch for [PATCH 1/2].

This line is not relevant once the patch gets committed.

> 
> Make the structures const as they are either passed to the function

Patch description should be readable independent of subject line so we
need to be more specific than "the structures"

> davinci_common_init having the argument as const or their field cpu_clks
> of type struct clk_lookup * is passed to the function davinci_clk_init.
> So, the fields are never modified and the structures can be const. 
> 
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

I made fixes to commit description per above and here is the updated text.

"
ARM: davinci: make davinci_soc_info structures const

Make davinci_soc_info structures const as they are either passed to the
function davinci_common_init having the argument as const or their field
cpu_clks of type struct clk_lookup * is passed to the function
davinci_clk_init.

So, the fields are never modified and the structures can be const.

Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
[nsekhar@...com: minor commit message adjustment]
Signed-off-by: Sekhar Nori <nsekhar@...com>
"

With that I applied the patch to v4.16/fixes-non-critical

Thanks,
Sekhar