linux-kernel - Re: [PATCH] scsi: debug: remove jiffies_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ef3fdc8-8e61-0e67-a3f9-be2dc36d8e50@interlog.com>
Date:   Mon, 27 Nov 2017 14:29:58 +0100
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     y2038@...ts.linaro.org, Bart Van Assche <bart.vanassche@....com>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: debug: remove jiffies_to_timespec

On 2017-11-27 12:36 PM, Arnd Bergmann wrote:
> There is no need to go through an intermediate timespec to convert
> to ktime_t when we just want a simple multiplication. This gets
> rid of one of the few users of jiffies_to_timespec, which I
> hope to remove as part of the y2038 cleanup.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Acked-by: Douglas Gilbert <dgilbert@...erlog.com>

> ---
>   drivers/scsi/scsi_debug.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index e4f037f0f38b..df7e9db44d44 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -4085,10 +4085,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd, struct sdebug_dev_info *devip,
>   		ktime_t kt;
>   
>   		if (delta_jiff > 0) {
> -			struct timespec ts;
> -
> -			jiffies_to_timespec(delta_jiff, &ts);
> -			kt = ktime_set(ts.tv_sec, ts.tv_nsec);
> +			kt = ns_to_ktime((u64)delta_jiff * (NSEC_PER_SEC / HZ));
>   		} else
>   			kt = sdebug_ndelay;
>   		if (NULL == sd_dp) {
>