linux-kernel - Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a3a67d43-3169-a067-7caf-349b9b1e2dba@acm.org>
Date:   Mon, 27 Nov 2017 08:22:07 -0600
From:   Corey Minyard <minyard@....org>
To:     David Binderman <dcb314@...mail.com>,
        "openipmi-developer@...ts.sourceforge.net" 
        <openipmi-developer@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if
 condition ?

On 11/27/2017 06:32 AM, David Binderman wrote:
> Hello there,
>
> linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279
>
> Source code is
>
>      if (new_smi->pdev) {
>          platform_device_unregister(new_smi->pdev);
>          new_smi->pdev = NULL;
>      } else if (new_smi->pdev) {
>
> Suggest code rework.

Yeah, definitely wrong, fix is queues for next release.  Thanks.

-corey

>
> Regards
>
> David Binderman