lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Nov 2017 15:55:28 +0100 From: walter harms <wharms@....de> To: Colin King <colin.king@...onical.com> CC: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size Am 27.11.2017 13:58, schrieb Colin King: > From: Colin Ian King <colin.king@...onical.com> > > Don't populate array 'names' on the stack but instead make them static. > Makes the object code smaller by 50 bytes: > > Before: > text data bss dec hex filename > 21237 9192 1120 31549 7b3d linux/sound/drivers/dummy.o > > After: > text data bss dec hex filename > 21095 9280 1120 31495 7b07 linux/sound/drivers/dummy.o > > (gcc version 7.2.0 x86_64) > > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > sound/drivers/dummy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c > index 7b2b1f766b00..69db45bc0197 100644 > --- a/sound/drivers/dummy.c > +++ b/sound/drivers/dummy.c > @@ -830,7 +830,7 @@ static int snd_dummy_capsrc_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el > static int snd_dummy_iobox_info(struct snd_kcontrol *kcontrol, > struct snd_ctl_elem_info *info) > { > - const char *const names[] = { "None", "CD Player" }; > + static const char *const names[] = { "None", "CD Player" }; > > return snd_ctl_enum_info(info, 1, 2, names); > } nitpick: while here snd_ctl_enum_info(info, 1, ARRAY_SIZE(names), names); just my 2 cents, re, wh
Powered by blists - more mailing lists