linux-kernel - RE: [PATCH] scsi: bfa: use setup_timer instead of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY2PR0701MB202393D9B8896207476F83D38E250@BY2PR0701MB2023.namprd07.prod.outlook.com>
Date:   Mon, 27 Nov 2017 05:36:13 +0000
From:   "Gurumurthy, Anil" <Anil.Gurumurthy@...ium.com>
To:     Colin King <colin.king@...onical.com>,
        "Kalluru, Sudarsana" <Sudarsana.Kalluru@...ium.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: bfa: use setup_timer instead of init_timer


-----Original Message-----
From: Colin King [mailto:colin.king@...onical.com] 
Sent: 24 November 2017 19:14
To: Gurumurthy, Anil <Anil.Gurumurthy@...ium.com>; Kalluru, Sudarsana <Sudarsana.Kalluru@...ium.com>; James E . J . Bottomley <jejb@...ux.vnet.ibm.com>; Martin K . Petersen <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: bfa: use setup_timer instead of init_timer

From: Colin Ian King <colin.king@...onical.com>

Use setup_timer function instead of initializing timer with the function and data fields.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/scsi/bfa/bfad.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index 5caf5f3ff642..c910b238bc9e 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -719,10 +719,7 @@ bfad_bfa_tmo(unsigned long data)  void  bfad_init_timer(struct bfad_s *bfad)  {
-	init_timer(&bfad->hal_tmo);
-	bfad->hal_tmo.function = bfad_bfa_tmo;
-	bfad->hal_tmo.data = (unsigned long)bfad;
-
+	setup_timer(&bfad->hal_tmo, bfad_bfa_tmo, (unsigned long)bfad);
 	mod_timer(&bfad->hal_tmo,
 		  jiffies + msecs_to_jiffies(BFA_TIMER_FREQ));
 }
--
2.14.1
 
Acked-by: Anil Gurumurthy <anil.gurumurthy@...ium.com>