lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 27 Nov 2017 17:05:53 +0200
From:   Andy Shevchenko <>
To:     Arnd Bergmann <>, Alan Cox <>,
        Sakari Ailus <>,
        Mauro Carvalho Chehab <>,
        Greg Kroah-Hartman <>
Subject: Re: [PATCH 7/8] [media] staging: atomisp: convert timestamps to

On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote:
> timespec overflows in 2038 on 32-bit architectures, and the
> getnstimeofday() suffers from possible time jumps, so the
> timestamps here are better done using ktime_get(), which has
> neither of those problems.
> In case of ov2680, we don't seem to use the timestamp at
> all, so I just remove it.

> +	ktime_t timedelay = ns_to_ktime(
>  		min((u32)abs(dev->number_of_steps) *
> -	};
> +		    (u32)DELAY_MAX_PER_STEP_NS));

Since you are touching this, it might make sense to convert to

min_t(u32, ...)

...and locate lines something like:

ktime_t timeday = ns_to_ktime(min_t(u32,

>From my pov will make readability better.

Andy Shevchenko <>
Intel Finland Oy

Powered by blists - more mailing lists