linux-kernel - Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511799651.2950.4.camel@intel.com>
Date:   Mon, 27 Nov 2017 16:21:34 +0000
From:   "Bernat, Yehezkel" <yehezkel.bernat@...el.com>
To:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
CC:     "andreas.noever@...il.com" <andreas.noever@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jamet, Michael" <michael.jamet@...el.com>
Subject: Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when
 polling starts

On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote:
> When ring enters polling mode we are expected to mask the ring
> interrupt
> before the callback is called. However, the current code actually
> unmasks it probably because of a copy-paste mistake.
> 
> Mask the interrupt properly from now on.
> 
> Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings")
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
>  drivers/thunderbolt/nhi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
> index 419a7a90bce0..f45bcbc63738 100644
> --- a/drivers/thunderbolt/nhi.c
> +++ b/drivers/thunderbolt/nhi.c
> @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring
> *ring)
>  		return;
>  
>  	if (ring->start_poll) {
> -		__ring_interrupt_mask(ring, false);
> +		__ring_interrupt_mask(ring, true);
>  		ring->start_poll(ring->poll_data);
>  	} else {
>  		schedule_work(&ring->work);

Acked-by: Yehezkel Bernat <yehezkel.bernat@...el.com>