linux-kernel - Re: [PATCH] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171127165942.GQ28152@atomide.com>
Date:   Mon, 27 Nov 2017 08:59:42 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Keerthy <j-keerthy@...com>
Cc:     linux-arm-kernel@...ts.infradead.org, rnayak@...eaurora.org,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        t-kristo@...com
Subject: Re: [PATCH] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst
 function

* Keerthy <j-keerthy@...com> [171110 03:29]:
> Referring TRM Am335X series:
> http://www.ti.com/lit/ug/spruh73p/spruh73p.pdf
> 
> The LastPowerStateEntered bitfield is present only for PM_CEFUSE
> domain. This is not present in any of the other power domains. Hence
> remove the generic am33xx_pwrdm_read_prev_pwrst hook which wrongly
> reads the reserved bit fields for all the other power domains.
> 
> Reading the reserved bits leads to wrongly interpreting the low
> power transitions for various power domains that do not have the
> LastPowerStateEntered field. The pm debug counters values are wrong
> currently as we are incrementing them based on the reserved bits.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>

Applying into omap-for-v4.15/fixes thanks.

Tony