linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d316f3a-bcb7-439c-fad3-90ffaad73e59@deltatee.com>
Date:   Mon, 27 Nov 2017 10:33:02 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Joe Perches <joe@...ches.com>, Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line

>> This is a valid false positive that I also missed. However, it can
>> actually be very easily ignored by checking if the format string ends in
>> %pV. There were about 100 cases in my results that match this.
> 
> No, it can't be done that way.
> 
> $ git grep '%pV\\n"' | wc -l
> 56
> $ git grep '%pV"' | wc -l
> 146
> 
> AFAIK: all of the above are correct as-is.

Yes, I'm saying they are correct too. So the script would very easily 
notice this and not produce a warning. The first grep you did already 
weren't false positives because they ended in \\n and wouldn't have 
produced a warning. A very simple change to my patch ignores the second 
group. So what's wrong here?

Logan