linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511804568.32426.56.camel@perches.com>
Date:   Mon, 27 Nov 2017 09:42:48 -0800
From:   Joe Perches <joe@...ches.com>
To:     Logan Gunthorpe <logang@...tatee.com>,
        Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line

On Mon, 2017-11-27 at 10:35 -0700, Logan Gunthorpe wrote:
> 
> On 27/11/17 10:28 AM, Joe Perches wrote:
> > It doesn't miss any mark.  It simply informs.
> > Correctness when fixing are a different world of problems.
> 
> So how come the double standard?

No double stardard.  One correctly informs that a bare
printk is not acceptable.

>  Having a missing new line warning 
> simply informs here too.

No it has a high false positive rate and newbies
act on that by submitting bad patches.'