linux-kernel - Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 13:07:15 -0500
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'SF Markus Elfring'" <elfring@...rs.sourceforge.net>,
        <linux-fbdev@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@...sung.com>
Cc:     "'LKML'" <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()

On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 26 Nov 2017 15:03:03 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> ---
>  drivers/video/fbdev/s3c-fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 0914c973cbd9..8c7623d63eb1 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
> 
> -	sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
> +	sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL);
>  	if (!sfb)
>  		return -ENOMEM;
> 
> --
> 2.15.0