linux-kernel - Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171128130154.GA20829@kroah.com>
Date:   Tue, 28 Nov 2017 14:01:54 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     Marcus Wolf <linux@...f-Entwicklungen.de>,
        Joseph Wright <rjosephwright@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Elia Geretto <elia.f.geretto@...il.com>,
        Srishti Sharma <srishtishar@...il.com>,
        Xiangyang Zhang <xyz.sun.ok@...il.com>,
        Derek Robson <robsonde@...il.com>,
        Cihangir Akturk <cakturk@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace
 coding style issues

On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote:
> Fix if/else if and braces in function DIO0_irq_handler to comply with
> the kernel coding style.
> 
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d946838450d4..dee70c47629c 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,14 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
>  {
>  	struct pi433_device *device = dev_id;
>  
> -	if      (device->irq_state[DIO0] == DIO_PacketSent)
> -	{
> +	if      (device->irq_state[DIO0] == DIO_PacketSent) {

When you are touching the line, be sure to fix the obvious space issue
here as well.

thanks,

greg k-h