linux-kernel - Re: [PATCH] gfs2: Fix wrong error handling in init_gfs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 08:41:36 -0500 (EST)
From:   Bob Peterson <rpeterso@...hat.com>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     Steven Whitehouse <swhiteho@...hat.com>, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gfs2: Fix wrong error handling in init_gfs2_fs()

----- Original Message -----
| init_gfs2_fs() is calling e.g. calling unregister_shrinker() without
| register_shrinker() when an error occurred during initialization.
| Rename goto labels and call appropriate undo function.
| 
| Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
| ---
|  fs/gfs2/main.c | 90
|  ++++++++++++++++++++++++++++------------------------------
|  1 file changed, 44 insertions(+), 46 deletions(-)
Hi,

ACK.

Thanks; this is a nice cleanup.

This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=8b0d7f56b97b95a442b6785027a0f80ad1ea54af

Regards,

Bob Peterson
Red Hat File Systems