linux-kernel - Re: [PATCH V3 03/29] x86/PCI: deprecate pci_get_bus_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 14:45:55 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Sinan Kaya <okaya@...eaurora.org>
cc:     linux-pci@...r.kernel.org, timur@...eaurora.org,
        linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        intel-gfx@...ts.freedesktop.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 03/29] x86/PCI: deprecate pci_get_bus_and_slot()


On Mon, 27 Nov 2017, Sinan Kaya wrote:

> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.
> 
> Getting ready to remove pci_get_bus_and_slot() function in favor of
> pci_get_domain_bus_and_slot().
> 
> Use domain number of 0 as the domain number is not available in struct
> irq_routing_table.
> 
> Signed-off-by: Sinan Kaya <okaya@...eaurora.org>

Acked-by: Thomas Gleixner <tglx@...utronix.de>

> ---
>  arch/x86/pci/irq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
> index 04526291..52e5510 100644
> --- a/arch/x86/pci/irq.c
> +++ b/arch/x86/pci/irq.c
> @@ -839,7 +839,8 @@ static void __init pirq_find_router(struct irq_router *r)
>  	DBG(KERN_DEBUG "PCI: Attempting to find IRQ router for [%04x:%04x]\n",
>  	    rt->rtr_vendor, rt->rtr_device);
>  
> -	pirq_router_dev = pci_get_bus_and_slot(rt->rtr_bus, rt->rtr_devfn);
> +	pirq_router_dev = pci_get_domain_bus_and_slot(0, rt->rtr_bus,
> +						      rt->rtr_devfn);
>  	if (!pirq_router_dev) {
>  		DBG(KERN_DEBUG "PCI: Interrupt router not found at "
>  			"%02x:%02x\n", rt->rtr_bus, rt->rtr_devfn);
> -- 
> 1.9.1
> 
>