linux-kernel - Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64b581c0-059f-bdea-d661-bcbdd8d1d1a4@microchip.com>
Date:   Tue, 28 Nov 2017 16:41:55 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>,
        <alexandre.belloni@...e-electrons.com>,
        <linux-pcmcia@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()

On 28/11/2017 at 16:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

okay...
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>  drivers/pcmcia/at91_cf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 87147bcd1655..7da7b0f0ae1b 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
>  	pdev->dev.platform_data = board;
>  
>  	mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
> -	if (IS_ERR(mc))
> -		return PTR_ERR(mc);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(mc);
>  }
>  #else
>  static int at91_cf_dt_init(struct platform_device *pdev)
> 


-- 
Nicolas Ferre