linux-kernel - Re: [PATCH] misc: vexpress: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171128155352.GS1119@e110455-lin.cambridge.arm.com>
Date:   Tue, 28 Nov 2017 15:53:52 +0000
From:   Liviu Dudau <liviu.dudau@....com>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org, sudeep.holla@....com,
        lorenzo.pieralisi@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO()

On Tue, Nov 28, 2017 at 04:20:43PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

Acked-by: Liviu Dudau <liviu.dudau@....com>

> ---
>  drivers/misc/vexpress-syscfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
> index 2cde80c7bb93..9eea30f54fd6 100644
> --- a/drivers/misc/vexpress-syscfg.c
> +++ b/drivers/misc/vexpress-syscfg.c
> @@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
>  	/* Must use dev.parent (MFD), as that's where DT phandle points at... */
>  	bridge = vexpress_config_bridge_register(pdev->dev.parent,
>  			&vexpress_syscfg_bridge_ops, syscfg);
> -	if (IS_ERR(bridge))
> -		return PTR_ERR(bridge);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bridge);
>  }
>  
>  static const struct platform_device_id vexpress_syscfg_id_table[] = {
> -- 
> 1.9.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯