linux-kernel - Re: [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 21:29:36 +0530
From:   arvindY <arvind.yadav.cs@...il.com>
To:     dmitry.torokhov@...il.com, maxime.ripard@...e-electrons.com,
        wens@...e.org, mcuos.com@...il.com, linux@...ck-us.net,
        linux@...linux.org.uk, lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's
 error checking

Hi Dmitry,

Sorry for troubling you. I need to push others also. Please share
your review comment.

Thanks,

On Tuesday 21 November 2017 09:41 PM, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> changes in v2 :
>                Return keypad->irq insted of -ENXIO.
> changes in v3 :
>                Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v4 :
>                Return -ENXIO insted of keypad->irq. Which was not correct in v3.
> changes in v5 :
>                Remove changes of v3 and v4. go back to version v2. Which is correct.
>                No need to check for IRQ0 and return keypad->irq insted of -ENXIO.
>
>   drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..01788a7 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
>   	}
>   
>   	keypad->irq = platform_get_irq(pdev, 0);
> -	if (!keypad->irq) {
> -		err = -ENXIO;
> +	if (keypad->irq < 0) {
> +		err = keypad->irq;
>   		goto failed_free;
>   	}
>