linux-kernel - Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 08:07:44 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Julius Werner <jwerner@...omium.org>,
        Eric Anholt <eric@...olt.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        linux-usb@...r.kernel.org, John Youn <johnyoun@...opsys.com>,
        Johan Hovold <johan@...nel.org>,
        Alexandru M Stan <amstan@...omium.org>,
        linux-rpi-kernel@...ts.infradead.org,
        Alyssa Rosenzweig <alyssa@...enzweig.io>
Subject: Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi,

On Tue, Nov 28, 2017 at 6:37 AM, Stefan Wahren <stefan.wahren@...e.com> wrote:
> Hi Doug,
>
> Doug Anderson <dianders@...omium.org> hat am 30. Oktober 2017 um 18:14
> geschrieben:
>
> Hi,
>
> On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <balbi@...nel.org> wrote:
>>
>
> Hi,
>
> Doug Anderson <dianders@...omium.org> writes:
>
> Hi,
>
> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren <stefan.wahren@...e.com>
> wrote:
>
> Hi Doug,
>
> [add Felipe since this should go through his tree]
>
> Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past
>
> No problems :-)
>
> but for some reason get_maintainer didn't ID you so I thought maybe
> you weren't doing it anymore. Please let me know if you'd like me to
> send this to you again with collected Reviewed-by and Tested-by tags.
>
> Yeah, please resend with all tags collected, however let's wait for a
> week or so and give other people time to catch up. I already sent my
> pull request to Greg, this would, anyway, go into the -rc cycle.
>
> Doh! I just re-read this one more time (after sending v3) and
> realized I had read it incorrectly. I read it as "please send the
> patch with the tags and I'll wait a week before landing", but you
> actually said "please wait a week before re-sending". Sorry for the
> noise. In the very least, you should be on the "To" line now so if
> anyone else has any extra tags it should be very easy for you to see
> them.
>
> Right that there's no massive urgency. It's been broken forever.
>
> since 4.15rc1 is out, how are your plans for the next Patch version?

Yeah, I was going to wait a week or so before pestering Felipe since
some people are still in Thanksgiving holiday mode and rc1 _just_ came
out...  My understanding is that the existing v3 patch is OK as-is and
I wasn't planning to send another one.  patchwork.kernel.org IDs for
the most recent version:

10032939 New          [v3,1/2] usb: dwc2: host: Don't retry NAKed
transactions right away
10032935 New          [v3,2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

-Doug