linux-kernel - Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b13bd723-3072-bb9e-c99a-b19141915d86@nokia.com>
Date:   Tue, 28 Nov 2017 20:16:20 +0200
From:   Tommi Rantala <tommi.t.rantala@...ia.com>
To:     David Miller <davem@...emloft.net>
Cc:     jon.maloy@...csson.com, ying.xue@...driver.com,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in
 tipc_udp_recv()

On 28.11.2017 16:58, David Miller wrote:
> From: Tommi Rantala <tommi.t.rantala@...ia.com>
> Date: Tue, 28 Nov 2017 14:53:15 +0200
> 
>> -
>> -	if (unlikely(msg_user(hdr) == LINK_CONFIG)) {
>> -		err = tipc_udp_rcast_disc(b, skb);
>> -		if (err)
>> -			goto rcu_out;
>> +	} else {
>> +		if (unlikely(b && msg_user(hdr) == LINK_CONFIG))
>> +			tipc_udp_rcast_disc(b, skb);
>> +		kfree_skb(skb);
>>   	}
> 
> Either put the 'err' propagation back or clearly explain in your
> commit log message why this part of the change if absolutely essential
> for this bug fix.
> 
> Thank you.
> 

Thanks for the feedback. I'll post patch v2 soon.

-Tommi