linux-kernel - Re: [PATCH v2] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171128102303.72b4d0a3@cakuba.netronome.com>
Date:   Tue, 28 Nov 2017 10:23:03 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Nicolai Stange <nicstange@...il.com>, linux-kernel@...r.kernel.org,
        oss-drivers@...ronome.com, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] debugfs: add definition of debugfs_real_fops() if
 CONFIG_DEBUG_FS unset

On Tue, 28 Nov 2017 15:23:00 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 12:35:44PM -0800, Jakub Kicinski wrote:
> > Recent commit moved the implementation of debugfs_real_fops()
> > out of the header file.  The declaration, however, is only
> > provided if CONFIG_DEBUG_FS is set.  Add an empty static inline
> > definition for when CONFIG_DEBUG_FS is unset.
> > 
> > Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata")
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > ---
> >  include/linux/debugfs.h | 5 +++++
> >  1 file changed, 5 insertions(+)  
> 
> Arnd sent me a better patch for this last week that I'll queue up now.

Arnd's patch assumes all call sites can be eliminated, i.e. all of the
users are static functions assigned to static fops and compiler is
clever enough.  It does solve my immediate problem but let's wait and
see if that bites us on the rear later :)