linux-kernel - Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f60a192f-c83e-9a27-4d4a-64cecaeb9378@daenzer.net>
Date:   Tue, 28 Nov 2017 20:41:47 +0100
From:   Michel Dänzer <michel@...nzer.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in
 hp_wmi_hw_state

On 2017-11-28 08:30 PM, Andy Shevchenko wrote:
> On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer <michel@...nzer.net> wrote:
>> On 2017-11-28 05:57 PM, Darren Hart wrote:
>>> On Tue, Nov 28, 2017 at 04:17:58PM +0100, Michel Dänzer wrote:
>>>> We were always checking bit 0 (which represents the docked state)
>>>> regardless of the mask.
>>>>
>>>> Fixes the "tablet mode" state always being reported the same as the
>>>> docked state, which with current libinput can cause the built-in input
>>>> devices of laptops to be incorrectly disabled while docked.
> 
>>> Merged in 4.15-rc1
>>
>> AFAIK commits without
>>
>>  Cc: stable@...r.kernel.org
>>
>> don't get automatically picked up for stable branches. Can you manually
>> nominate 9968e12 for stable?
> 
> AFAIK Greg picks up patches based on Fixes tag as well.
> Feel free to ping us or just forward that one yourself if Greg will
> not pick up in reasonable (month?) time.

Both 4.14.1 and 4.14.2 were released after Linus merged the fix, but
neither has it. Given that, and that a fair number of people seem to be
running into this, seems like a good idea to do it ASAP.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer